dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `COMMAND DOCS`

Open arpitbbhayani opened this issue 1 year ago • 9 comments

Add support for the COMMAND DOCS command in DiceDB similar to the COMMAND DOCS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

hi @arpitbbhayani can you assign this to me

sa-k-shore avatar Sep 20 '24 18:09 sa-k-shore

Hi @arpitbbhayani , I have already worked upon the COMMAND INFO, Can I work on COMMAND DOCS too ?

meetghodasara avatar Sep 21 '24 06:09 meetghodasara

Hi @arpitbbhayani Can I take this up?

karandixit10 avatar Sep 21 '24 08:09 karandixit10

hi @arpitbbhayani can you assign this to me

Assigned

JyotinderSingh avatar Sep 23 '24 02:09 JyotinderSingh

Hey @arpitbbhayani , why do we have 2 duplicate issues for the same? https://github.com/DiceDB/dice/issues/146

adityadhiman12 avatar Sep 26 '24 19:09 adityadhiman12

Hello @sa-k-shore,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 03 '24 14:10 arpitbbhayani

hi @arpitbbhayani sorry for delay i have few doubts if i want to show complexity etc with command docs , should i add those in cmdMeta , i can see this data in dice-cli in commands.js and also if we call command docs command or command info command it wont work as its name is stored as command had raised a issue #758 . I have written basic code without test cases for docs and changed code to some degree for info . i was thinking i should add complexity , since etc also to DiceCmdMeta and wrote code or should we have a json and read from that , thanks

sa-k-shore avatar Oct 03 '24 14:10 sa-k-shore

i have raised a Merge Request but its still not up to make with redis still many fields are not present when compared with redis #993 . please review, thanks.

sa-k-shore avatar Oct 07 '24 12:10 sa-k-shore

Hello @sa-k-shore,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

Closing merged as part of https://github.com/DiceDB/dice/pull/993

lucifercr07 avatar Oct 24 '24 15:10 lucifercr07