dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

#570:SETEX command Feature

Open AshikBN opened this issue 1 year ago • 2 comments

Added support for SETEX command #570

AshikBN avatar Sep 15 '24 12:09 AshikBN

@AshikBN please rebase to resolve conflicts.

lucifercr07 avatar Sep 16 '24 13:09 lucifercr07

rebase is done.pls check @lucifercr07

AshikBN avatar Sep 18 '24 02:09 AshikBN

made the relevant changes, pls review @kushal0511-not

AshikBN avatar Sep 21 '24 08:09 AshikBN

Thanks for changes @AshikBN . Could you please address @JyotinderSingh 's comments also? https://github.com/DiceDB/dice/pull/590#discussion_r1766202956 and https://github.com/DiceDB/dice/pull/590#discussion_r1766203251

kushal0511-not avatar Sep 21 '24 10:09 kushal0511-not

done @kushal0511-not

AshikBN avatar Sep 21 '24 10:09 AshikBN

@AshikBN Thanks for changes. LGTM. Just add comment to function.

kushal0511-not avatar Sep 21 '24 10:09 kushal0511-not

added comments @kushal0511-not

AshikBN avatar Sep 21 '24 11:09 AshikBN

Thanks for adding support for the SETEX command, @AshikBN! Thank you for the reviews @kushal0511-not.

The changes had gone out of date and weren't compatible with the new code anymore, since the SET command has been migrated to the new multi-shard setup. I have patched my changes into this PR to migrate SETEX as well.

Merging this now.

JyotinderSingh avatar Sep 23 '24 10:09 JyotinderSingh