#495: Implementation `JSON.FORGET` command
Implementation for Issue : 495
- Add JSON.FORGET command implementation , refer : JSON.FORGET
- Add Unit Test for JSON.FORGET
- Add Integration Test for JSON.FORGET
Attaching below the screenshots of behavior of: 1. JSON.FORGET command in Redis:
2. JSON.FORGET command in dice
Thanks for contributing @Nijin-P-S . I see JSON.FORGET is just alias of JSON.DEL command in docs. So instead of writing same code again can we just call JSON.DEL command inside it.wdyt? Correct if me i am missing something.
Yes @kushal0511-not , That should work.Calling the DEL function inside the JSON.FORGET would be better. Let me make the changes necessary and remove the excessive code.
@kushal0511-not , Have updated the implementation to call the evalJSONDEL() thus reducing the code repeatation. Cross verified the unit tests, Integration tests and functionality, and is working as expected.
Attaching the screenshots:
-
Unit Tests
-
Integration Test
-
Functionality
Let me know if anything needs to be modified or added.
Thanks.
@Nijin-P-S , LGTM Just one minor comment. Thanks for changes.
@kushal0511-not , Made the changes.
Thanks.
Hi @lucifercr07 , Made the necessary changes as mentioned, please have a look.
Thanks