dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `EXPIRE`: EXPIRE with XX option on a key without ttl

Open AshwinKul28 opened this issue 1 year ago • 4 comments

Steps to reproduce

Run the commands mentioned in the test on Line 493 in the file https://github.com/AshwinKul28/dice-tests/tree/main/tcltests/unit/expire.tcl#L493.

Expected output

The expected output when the above set of commands when run on Redis

-1

Observed output

The observed output when the above set of commands when run on DiceDB

199

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. Successful run of the tcl test behavior

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

AshwinKul28 avatar Sep 08 '24 19:09 AshwinKul28

@arpitbbhayani @AshwinKul28 Can you please assign this issue to me?

jainam2907 avatar Sep 08 '24 22:09 jainam2907

@jainam2907 assigned. Thank you for taking this up.

arpitbbhayani avatar Sep 09 '24 03:09 arpitbbhayani

HI @jainam2907 Can you please add evidence to all the fixes. Please run the test and provide observed outputs.

AshwinKul28 avatar Sep 09 '24 06:09 AshwinKul28

Hi @AshwinKul28, Sorry for the delay. I have added the RCA, resolution, and the tcl test output here.

jainam2907 avatar Sep 10 '24 05:09 jainam2907