dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `EXPIRE`: EXPIRE with big integer overflows when converted to milliseconds

Open AshwinKul28 opened this issue 1 year ago • 4 comments

Steps to reproduce

Run the commands mentioned in the test on Line 110 in the file https://github.com/AshwinKul28/dice-tests/tree/main/tcltests/unit/expire.tcl#L110.

Expected output

The expected output when the above set of commands when run on Redis

ERR invalid expire time in 'expire' command

Observed output

The observed output when the above set of commands when run on DiceDB

1

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. Successful run of the tcl test behavior

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

AshwinKul28 avatar Sep 08 '24 18:09 AshwinKul28

@AshwinKul28 if you aren't working on this, could you please assign this to me

raghavbabbar avatar Sep 08 '24 18:09 raghavbabbar

@raghavbabbar :D you have one JSON issue already assigned, wrap that up first :) then you can pick others. once again, thank you for being so eager :D

arpitbbhayani avatar Sep 08 '24 19:09 arpitbbhayani

@AshwinKul28 @arpitbbhayani please assign this to me

ashwaniYDV avatar Sep 08 '24 19:09 ashwaniYDV

@ashwaniYDV Go for it and thanks for taking this up.

arpitbbhayani avatar Sep 08 '24 19:09 arpitbbhayani