dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `JSON.DEBUG HELP`

Open arpitbbhayani opened this issue 1 year ago • 3 comments

Add support for the JSON.DEBUG HELP command in DiceDB similar to the JSON.DEBUG HELP command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 08 '24 18:09 arpitbbhayani

I think issue #493 will be sufficient for this.

kaifkh20 avatar Sep 09 '24 08:09 kaifkh20

I agree.

@lucifercr07 - #491 #492 and #493 are referring to just one command with two subcommands: json.debug help and json.debug memory. The former subcommand is just help text. Should we combine these 3 as one issue?

psrvere avatar Sep 09 '24 09:09 psrvere

We can keep the issues open as it is for reference purpose. You can work on both i.e. #492 and #493 together, will assign.

lucifercr07 avatar Sep 09 '24 09:09 lucifercr07