DiceDB
Setup Zap logger
We should replace the current logger ("github.com/charmbracelet/log") with Zap for better performance.
@Dev79844 I have already written a variant for it. If it's ok, can i take this up?
@icetech233 would love to hear more on this. Why do you think zerolog is best?
Should be easy to benchmark this (zap vs zerolog vs others)? Or refer to an existing benchmark.
Also, i have closed a task to unify logging so please include that in scope once we have decided on the logging lib.
@icetech233 would love to hear more on this. Why do you think zerolog is best?
the most fast
I have been using zerolog from a long time. And yes it has a performance advantage mentioned in these benchmarks . In our last discussion I missed to mention this @soumya-codes . We can actually go with the zerolog instead of zap.
Why not just go ahead with slog?
This is a nice talk which the Go team gave about logging in Go https://youtu.be/8rnI2xLrdeM?si=bllbR3HBMi9sUJbw
Hey guys is there a consensus on this? And is anybody looking to pick it up? If not I would like to pick it up
@AshwinKul28 @JyotinderSingh can I go ahead with zerolag? I want to pick it up.
@AshwinKul28 @JyotinderSingh can I go ahead with zerolag? I want to pick it up.
I believe @AshwinKul28 is already tackling this
@kaviisuri thanks for contributing, can you please comment once so I can assign. cc: @AshwinKul28
This can be closed since there's similar effort going on here - https://github.com/DiceDB/dice/issues/587