dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Report inconsistency in the command `GET`

Open arpitbbhayani opened this issue 1 year ago • 17 comments

This issue is all about ensuring we are as close to Redis as possible. The command in focus for this issue is GET.

Go through the official documentation of the command GET on Redis and identify the inconsistencies. The inconsistencies could be in

  1. unhandled edge case
  2. unexpected behavior
  3. unsupported option

Because we are trying to be compatible with Redis v7.2.5, I would recommend you try out different variants of the command with different inputs on that specific version. The instructions on running Redis v7.2.5 locally

Once you find the discrepancy, you can either

  1. raise an issue on Dice repository with details, or
  2. try to fix it yourself and raise a PR

If you are raising the issue, make sure you provide the details such as

  1. use the template and provide the following details
  2. steps to reproduce (series of commands)
  3. observed output on DiceDB
  4. observed output on Redis v7.2.5

Also, feel free to update the documentation and raise the PR in the docs repository.

You will need to go deeper into the command make sure you are covering all cases and reporting the inconsistencies or fixing them. The deeper the work, the better our stability will be. Also, it is possible that we do not find any discrepancies, so please mention the same in the comment on this issue. Mention the PR or issue links that you create under this issue.

arpitbbhayani avatar Aug 21 '24 17:08 arpitbbhayani

Hi ! @arpitbbhayani can i take this up ? Thank you !

liooooo29 avatar Aug 22 '24 01:08 liooooo29

@halalala222 go for it!

arpitbbhayani avatar Aug 22 '24 14:08 arpitbbhayani

Hi,

Is this still being worked on? Happy to give it a try

sbshah97 avatar Sep 01 '24 19:09 sbshah97

HI @sbshah97 Thanks for picking this up. Please post your updates regularly for easy tracking.

AshwinKul28 avatar Sep 08 '24 11:09 AshwinKul28

Hi thanks. Will leave an update later at night on this.

sbshah97 avatar Sep 09 '24 12:09 sbshah97

Hello might not be able to work on this. Caught up with office work.

Can we un-assign me so that we have someone else pick this up for now? @arpitbbhayani / @soumya-codes

sbshah97 avatar Sep 13 '24 09:09 sbshah97

@sbshah97 thanks for notifying me. really appreciate it. removing the assignment.

arpitbbhayani avatar Sep 13 '24 09:09 arpitbbhayani

Hi @arpitbbhayani , I would like to pick this up, can you assign me this task?

Nijin-P-S avatar Sep 13 '24 13:09 Nijin-P-S

Hello @arpitbbhayani, I'd like to pick it up!

hemantsharma1498 avatar Sep 14 '24 07:09 hemantsharma1498

Hello, @Nijin-P-S Go for it. 🚀 Thanks for the interest @hemantsharma1498 , Assigning to Nijin based on the priority, Feel free to pick any other open issue, or wait till a new one comes up.

AshwinKul28 avatar Sep 18 '24 20:09 AshwinKul28

Hi @AshwinKul28 ,

I wanted to reach out regarding the issues I was assigned. Despite my efforts, I’m finding it challenging to make progress on them. Additionally, I have a busy period at my full-time job coming up and won’t be able to dedicate the time needed for the next couple of weeks.

I think it would be best for me to unassign these issues so someone else can take them on. Thank you for understanding, and I hope to contribute again in the future!

Nijin-P-S avatar Sep 22 '24 17:09 Nijin-P-S

Hey @JyotinderSingh , Could you assign this to me, please?

meetghodasara avatar Sep 23 '24 02:09 meetghodasara

Hey @JyotinderSingh , Could you assign this to me, please?

Done

JyotinderSingh avatar Sep 23 '24 02:09 JyotinderSingh

While reviewing the inconsistency of GET command, I have listed 2 issue related to inconsistent behaviour.

Here are issues.

  1. https://github.com/DiceDB/dice/issues/516
  2. https://github.com/DiceDB/dice/issues/703

I have prepared the sheet of ongoing testing of GET command. You can refer here : Analysis of the command GET

Please let me know if you have any suggestions or feedback on where I can explore more scenarios for the GET command.

meetghodasara avatar Sep 23 '24 16:09 meetghodasara

I think we can close this issue. Please let me know if you have any suggestions or feedback.

meetghodasara avatar Sep 29 '24 09:09 meetghodasara

Hello @meetghodasara,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 09 '24 02:10 arpitbbhayani

Hello @meetghodasara,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani