DiceDB
Add Support for Boolean Values
- Implement GET and SET operations for boolean values
- Enable querying and retrieving boolean values in Json Set and Get Operations
- Enable querying boolean values in Json in QWATCH command
- Add unit and integration tests
- Perform and upload benchmarks
Hey @JyotinderSingh I just checked that redis does not support storing boolean values. Do we still want to add this feature? Considering this would it still make sense to retrieve boolean values from json or continue with the current functionality of returning strings instead?
Hey @JyotinderSingh I just checked that redis does not support storing boolean values. Do we still want to add this feature? Considering this would it still make sense to retrieve boolean values from json or continue with the current functionality of returning strings instead?
Boolean for JSON should probably be supported, right? Especially for our usecase of filtering on queries. I did add some logic to the executor to support json but haven't tested it yet. My hunch is that it does work already (or shouldn't require too much effort to make it work).
@soumya-codes any thoughts around this?
Sorry about the late response. Agree with @JyotinderSingh. Redis doesn't support boolean values as a first class type. The only place where we store boolean values is in JSON, which I think we already support.
Hey @soumya-codes @JyotinderSingh the JSON GET operation in redis returns an integer (0 if false or 1 if true) if we query a boolean path. If we are fixed on copying the entire functionality of redis I think this is the approach we should use. But otherwise I believe it is good user experience to return the type the user stored. If user stored a boolean value then we should return that rather than integer or string. But then again this all depends upon our use case and goals. What do you say?
To compare boolean in our qwatch expression some minor changes are needed. I'll finish that by the weekend and add tests for that as well. We also need to further testing in our qwatch integration tests. I will do that within that PR
HI @YahyaHaq , Let me know if you're busy right now with some other tasks, we will reassign this to some one else. Thanks
Hey @AshwinKul28 one portion of this task is almost done. This task will be done by this weekend
Hey @AshwinKul28 I wont be able to complete the task this week due to some errands. You can pick this up if you want
Hello @YahyaHaq,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
HI @arpitbbhayani. I informed last week that I will not be able to complete this task due to some personal commitments. I will unassign myself this. Apologies for any delay caused in this task. I completely understand your point and I will try to inform you earlier in case any situation like this comes up again. Thank you!