dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `WAIT`

Open arpitbbhayani opened this issue 1 year ago • 5 comments

Add support for the WAIT command in DiceDB similar to the WAIT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Aug 12 '24 21:08 arpitbbhayani

@arpitbbhayani could you please assign this to me?

raghavbabbar avatar Aug 13 '24 01:08 raghavbabbar

@raghavbabbar Go for it. Although we do not have replicas at the moment, accept that parameter for full compatibility but do not act on it.

arpitbbhayani avatar Aug 13 '24 06:08 arpitbbhayani

@raghavbabbar could you please add updates on your progress on the issue?

JyotinderSingh avatar Aug 17 '24 09:08 JyotinderSingh

https://discord.com/channels/1034342738960855120/1264145943884992595/1273975330780221522 As we don't have replica at the moment. what functionality are we expecting out from this issue. could you please help me @JyotinderSingh

raghavbabbar avatar Aug 17 '24 10:08 raghavbabbar

https://discord.com/channels/1034342738960855120/1264145943884992595/1273975330780221522 As we don't have replica at the moment. what functionality are we expecting out from this issue. could you please help me @JyotinderSingh

Makes sense, we can add this issue to the icebox for now.

JyotinderSingh avatar Aug 17 '24 10:08 JyotinderSingh