dice icon indicating copy to clipboard operation
dice copied to clipboard

KeyspaceStat Is not protected with a Mutex

Open JyotinderSingh opened this issue 1 year ago • 4 comments

KeyspaceStat is currently accessed by multiple methods without mutex, while this is not an issue at this point since we do not have concurrent execution of write commands but we should still look into it.

JyotinderSingh avatar Aug 10 '24 16:08 JyotinderSingh

Shall i look into it?

VipinRaiP avatar Aug 10 '24 16:08 VipinRaiP

@JyotinderSingh @gauravsarma1992 We are reading it's value in EvalInfo function without any locks, may be in other operations typical GET/DEL we are mutating it within locks[keypool, store]. but reads from EvalInfo at same time may create issue.

raghavbabbar avatar Aug 11 '24 11:08 raghavbabbar

Shall i look into it?

Sure, assigned @VipinRaiP

JyotinderSingh avatar Aug 18 '24 18:08 JyotinderSingh

Hello @VipinRaiP,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 09 '24 09:09 arpitbbhayani

We no longer have concurrent accesses on Keyspace stat, this bug is not relevant anymore.

JyotinderSingh avatar Sep 12 '24 17:09 JyotinderSingh