dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `HGETALL` Command

Open JyotinderSingh opened this issue 1 year ago • 6 comments

We need to implement the HGETALL command similar to the HGETALL command in Redis. This command returns all fields and values of the hash stored at key. Please refer to the following commit in Redis to understand the implementation specifics - source.

  1. Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5.
  2. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
  3. For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh avatar Aug 06 '24 12:08 JyotinderSingh

@JyotinderSingh , could you please assign this issue to me? I've created PR for my previous issue, may I work on it now? I've understood about this issue form the redis website 👍

yaten2302 avatar Aug 06 '24 18:08 yaten2302

Can I work on this? @JyotinderSingh I have been looking for a long time to find a single issue to work on. I hope I get the chance to work on this one.

raghavbabbar avatar Aug 07 '24 06:08 raghavbabbar

Can you please assign this to me @JyotinderSingh? I would like to contribute.

rajatx185 avatar Aug 07 '24 17:08 rajatx185

Can I work on this? @JyotinderSingh

I have been looking for a long time to find a single issue to work on. I hope I get the chance to work on this one.

Assigned

JyotinderSingh avatar Aug 08 '24 00:08 JyotinderSingh

Hello @raghavbabbar,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 09 '24 09:09 arpitbbhayani

we can close this, PR was merged 5 days back . @arpitbbhayani

raghavbabbar avatar Sep 10 '24 04:09 raghavbabbar

Hello @raghavbabbar,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 20 '24 18:09 arpitbbhayani

@arpitbbhayani the code of the same has been merged 15 days ago we can close this issue

raghavbabbar097 avatar Sep 20 '24 18:09 raghavbabbar097

Closing issue, merged as part of https://github.com/DiceDB/dice/pull/431.

lucifercr07 avatar Sep 20 '24 18:09 lucifercr07