dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `HSET` Command

Open JyotinderSingh opened this issue 1 year ago • 13 comments

We need to implement the HSET command similar to the HSET command in Redis. This command sets field in the hash stored at key to value. Please refer to the following commit in Redis to understand the implementation specifics - source.

  1. Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5.
  2. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
  3. For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh avatar Aug 06 '24 12:08 JyotinderSingh

@JyotinderSingh can you please assign this to me.

lucifercr07 avatar Aug 06 '24 12:08 lucifercr07

@JyotinderSingh , actually, I was reading about this command on the redis website, could you please guide that what's the use of the field option in this command? Like, HSET key field value [field value ...], in this I'm not able to understand the use of field option
image

yaten2302 avatar Aug 06 '24 12:08 yaten2302

@JyotinderSingh can you please assign this to me.

Would recommend taking up only one issue at a time to allow everyone a chance to contribute.

JyotinderSingh avatar Aug 06 '24 12:08 JyotinderSingh

@JyotinderSingh , actually, I was reading about this command on the redis website, could you please guide that what's the use of the field option in this command? Like, HSET key field value [field value ...], in this I'm not able to understand the use of field option

Explore the docs and play around, that is the best way to learn.

JyotinderSingh avatar Aug 06 '24 12:08 JyotinderSingh

Please assign this to me.

codeimmortal avatar Aug 06 '24 14:08 codeimmortal

Please assign this to me.

Assigned

JyotinderSingh avatar Aug 06 '24 15:08 JyotinderSingh

@JyotinderSingh could you please assign this to me?

kolharsam avatar Aug 06 '24 18:08 kolharsam

@JyotinderSingh could you please assign this to me?

Assigned

JyotinderSingh avatar Aug 07 '24 01:08 JyotinderSingh

Hi, @kolharsam Could you please let me know the ETA for this issue, looks like mine issue https://github.com/DiceDB/dice/issues/257 is dependent on this issue implementation. cc @JyotinderSingh

raghavbabbar avatar Aug 11 '24 10:08 raghavbabbar

Hi, @kolharsam Could you please let me know the ETA for this issue, looks like mine issue https://github.com/DiceDB/dice/issues/257 is dependent on this issue implementation. cc @JyotinderSingh

Hi @raghavbabbar sorry about the delay. Had a very busy weekend. Will update regarding this in a couple of days

kolharsam avatar Aug 12 '24 03:08 kolharsam

@kolharsam Are you actively working on this?

JyotinderSingh avatar Aug 17 '24 09:08 JyotinderSingh

Yes, @JyotinderSingh I am actively working on this. Will share some proper updates soon.

kolharsam avatar Aug 17 '24 16:08 kolharsam

Yes, @JyotinderSingh I am actively working on this. Will share some proper updates soon.

Awesome, thanks!

JyotinderSingh avatar Aug 17 '24 16:08 JyotinderSingh