dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `SCAN` Command

Open JyotinderSingh opened this issue 1 year ago • 14 comments

We need to implement the SCAN command similar to the SCAN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

  1. Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5.
  2. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
  3. For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh avatar Aug 06 '24 12:08 JyotinderSingh

Can I work on this? @JyotinderSingh I have been looking for a long time to find a single issue to work on.

raghavbabbar avatar Aug 07 '24 06:08 raghavbabbar

@JyotinderSingh Can you please assign this to me?

rajatx185 avatar Aug 07 '24 17:08 rajatx185

@JyotinderSingh Just a reminder, Can you assign this to me? I would like to contribute on this issue.

rajatx185 avatar Aug 10 '24 22:08 rajatx185

@JyotinderSingh Just a reminder, Can you assign this to me? I would like to contribute on this issue.

Assigned

JyotinderSingh avatar Aug 11 '24 05:08 JyotinderSingh

The issue is unassigned and available to be taken up.

JyotinderSingh avatar Aug 17 '24 09:08 JyotinderSingh

Hey @JyotinderSingh, can you please assign this issue to me.

rohitlohar45 avatar Aug 17 '24 10:08 rohitlohar45

Hey @JyotinderSingh, can you please assign this issue to me.

Assigned

JyotinderSingh avatar Aug 17 '24 10:08 JyotinderSingh

Hey @JyotinderSingh , I have created a PR #347 can you please check for logic if I am going in right direction. I have tested all possible methods possible for manual testing, currently writing test cases and understanding about integration tests. If the code looks good I can proceed further to write remaining tests. https://github.com/DiceDB/dice/pull/347

rohitlohar45 avatar Aug 19 '24 11:08 rohitlohar45

NEW PR https://github.com/DiceDB/dice/pull/425

rohitlohar45 avatar Aug 29 '24 16:08 rohitlohar45

Hello @rohitlohar45,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 09 '24 09:09 arpitbbhayani

Hey @arpitbbhayani, I am currently stuck at the data structure part for cloning the keypool, will update it as soon as possible but your inputs will be really helpful.

rohitlohar45 avatar Sep 09 '24 09:09 rohitlohar45

We cannot support this feature yet, so will be adding it into icebox for now. The related discussion around this decision can be viewed on PR #578.

JyotinderSingh avatar Sep 17 '24 19:09 JyotinderSingh

@JyotinderSingh can you assign this issue to me ??

toastsandwich avatar Oct 02 '24 12:10 toastsandwich

@JyotinderSingh can you assign this issue to me ??

We're not planning to work on this feature yet. Which is why it has the icebox label

JyotinderSingh avatar Oct 05 '24 01:10 JyotinderSingh