dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `PFCOUNT` command

Open Vsareen0 opened this issue 1 year ago • 2 comments

Add support for the PFCOUNT command in DiceDB similar to the PFCOUNT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

Vsareen0 avatar Aug 04 '24 17:08 Vsareen0

Hey @Vsareen0 Do you have any updates on this? If you have any blockers lets discuss this over the discord. Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up. Thanks

cc - @JyotinderSingh

AshwinKul28 avatar Aug 25 '24 18:08 AshwinKul28

Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up. Thanks

@AshwinKul28 Can I pick this up?

maniSHarma7575 avatar Aug 26 '24 01:08 maniSHarma7575

@JyotinderSingh we can close this issue as implemented as part of PR here.

lucifercr07 avatar Sep 03 '24 07:09 lucifercr07