dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `PFADD` command

Open Vsareen0 opened this issue 1 year ago • 7 comments

Add support for the PFADD command in DiceDB similar to the PFADD command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

Vsareen0 avatar Aug 04 '24 17:08 Vsareen0

Assigned to myself @JyotinderSingh / @arpitbbhayani

Vsareen0 avatar Aug 04 '24 18:08 Vsareen0

@Vsareen0 how close are we to completing this? what is ETA?

arpitbbhayani avatar Aug 19 '24 07:08 arpitbbhayani

Hey @arpitbbhayani Sorry for the delay, will try to close this by this Sunday.

Vsareen0 avatar Aug 20 '24 15:08 Vsareen0

hey @arpitbbhayani Sorry for time consumption, I tried but unable to write implementation for this. You can reassign to someone else.

Vsareen0 avatar Aug 25 '24 06:08 Vsareen0

Thanks @Vsareen0 for the update.

cc @JyotinderSingh Please open it for everyone and someone else can pick this up.

AshwinKul28 avatar Aug 25 '24 18:08 AshwinKul28

Hey @JyotinderSingh , I would like to take this up.

kailashchoudhary11 avatar Aug 25 '24 19:08 kailashchoudhary11

Have started working on this as part of assigned parent issue.

lucifercr07 avatar Aug 26 '24 10:08 lucifercr07

@JyotinderSingh we can close this issue as implemented as part of PR here.

lucifercr07 avatar Sep 03 '24 07:09 lucifercr07