dice icon indicating copy to clipboard operation
dice copied to clipboard

#222: Added Benchmark for negative number and close to MinInt64, MaxInt64

Open Vsareen0 opened this issue 1 year ago • 3 comments

  • Added benchmark for negative numbers and number close to MinInt64, MaxInt64
=== RUN   BenchmarkMinMaxEncodeDecodeInt
BenchmarkMinMaxEncodeDecodeInt
BenchmarkMinMaxEncodeDecodeInt-12       49743938                23.24 ns/op            7 B/op          1 allocs/op
PASS
ok      github.com/dicedb/dice/core/dencoding   1.396s

Vsareen0 avatar Aug 04 '24 04:08 Vsareen0

Hey @JyotinderSingh / @arpitbbhayani this test case is failing the build, I have verified on local, TestDecodeOneNoDataRead this one causes build to fail. if I comment this out, works expected !

Vsareen0 avatar Aug 04 '24 05:08 Vsareen0

Hey @JyotinderSingh / @arpitbbhayani this test case is failing the build, I have verified on local, TestDecodeOneNoDataRead this one causes build to fail. if I comment this out, works expected !

Fixed, please rebase.

JyotinderSingh avatar Aug 04 '24 05:08 JyotinderSingh

Thanks for quick resolution @JyotinderSingh !

Vsareen0 avatar Aug 04 '24 05:08 Vsareen0

I updated the benchmark structure a little for this file, could you please take a look at accordingly move this function into dencoding_benchmark_test.go?

JyotinderSingh avatar Aug 04 '24 16:08 JyotinderSingh

Thanks for guidance @JyotinderSingh , looks much cleaner now !

Vsareen0 avatar Aug 04 '24 16:08 Vsareen0