dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Add support for Basic Auth

Open gsarmaonline opened this issue 1 year ago • 6 comments

https://github.com/DiceDB/dice/issues/141

Prior to Redis 6, authentication for a connection was enabled by passing in requirepass in the redis.conf or while starting the redis server. If the above config is set, prior to any command, the authentication has to be by running the following command:

AUTH '<password>'

Screenshot 2024-08-03 at 10 21 05 PM

requirepass can be set in the config by changing config/main.go before running the server.

The storage of user credentials and ACLs will be implemented in the subsequent PRs.

gsarmaonline avatar Jul 24 '24 14:07 gsarmaonline

Hi @gauravsarma1992, thanks for this contribution. Could you please rebase this PR on master and resolve the conflicts? Will review once done.

JyotinderSingh avatar Jul 31 '24 01:07 JyotinderSingh

Hi @gauravsarma1992, thanks for this contribution. Could you please rebase this PR on master and resolve the conflicts? Will review once done.

Rebased the PR from the latest master.

gsarmaonline avatar Jul 31 '24 12:07 gsarmaonline

Please mark the PR ready for review once you are done with it.

JyotinderSingh avatar Jul 31 '24 13:07 JyotinderSingh

@JyotinderSingh Please review

gsarmaonline avatar Aug 03 '24 17:08 gsarmaonline

@arpitbbhayani Addressed the review comments. Please review again.

gsarmaonline avatar Aug 03 '24 23:08 gsarmaonline

@JyotinderSingh Please review

gsarmaonline avatar Aug 04 '24 10:08 gsarmaonline

Changes look good. Thanks :) merging them.

arpitbbhayani avatar Aug 05 '24 18:08 arpitbbhayani