dice icon indicating copy to clipboard operation
dice copied to clipboard

Update integration tests for Z* commands

Open arpitbbhayani opened this issue 8 months ago • 3 comments

Recently, we pushed an interesting change in Z* commands. We do not fetch and serve ranks for all sorted set elements by default. The current set of integration tests does not test it, we need to update it. Also, the test for ZRANK will break as the result structure has been altered, so that test also needs to be updated.

arpitbbhayani avatar Apr 29 '25 18:04 arpitbbhayani

Will pick up if no one is working on it .

vipul08 avatar Apr 29 '25 18:04 vipul08

@arpitbbhayani Can I pick this up?

VanshikaNavya avatar Apr 30 '25 13:04 VanshikaNavya

Referring to https://github.com/DiceDB/dice/pull/1712 The main change is from the method ZRANGE, while others include functional changes in cmd/ files.

Grepping over the repo I find the following test files use ZRANGE

  1. eval_test.go
  2. zrange_test.go
  3. zset_test.go

And with respect to ZRANK mentioned in the issue description the file

  1. zrank_test.go

Are we in the right direction ? @arpitbbhayani Any pointers please.

Shravanpmk avatar Apr 30 '25 18:04 Shravanpmk