dice icon indicating copy to clipboard operation
dice copied to clipboard

Running Watch command after closing first one doesn't work

Open Abhijeetsng97 opened this issue 8 months ago • 5 comments

Steps to reproduce: open 2 dice db cli in one cli at every interval keep on doing GET key in another cli stop a watch CMD and start agin it stops receving updates

Image

fix PR: https://github.com/DiceDB/dicedb-cli/pull/41 https://github.com/DiceDB/dicedb-go/pull/13

after fix:

Image

Abhijeetsng97 avatar Apr 17 '25 21:04 Abhijeetsng97

Is this still reproducible? We changed implementation of client-server communication, might have fixed it accidentally

mintobit avatar Apr 29 '25 14:04 mintobit

Hey will check and update I saw many changes in dicedb-go If any issue is there will push a fix

Abhijeetsng97 avatar Apr 29 '25 15:04 Abhijeetsng97

@mintobit @arpitbbhayani This issue isn't fixed with lastest changes in dicedb-go I raised a pr with changes but it had conflict https://github.com/DiceDB/dicedb-go/pull/13 Will raise another one in couple of days

Issue was mainly setting a read timeout while reading from TCP connection and handling of cancel in go channel

Abhijeetsng97 avatar Apr 30 '25 05:04 Abhijeetsng97

@Abhijeetsng97 I also got this issue, let me know if I can pick this up if you haven't started it

Kaushal-26 avatar May 04 '25 12:05 Kaushal-26

@mintobit I maintain dicedb-driver, js client for DiceDB, and can confirm this still exists, I had reported this issue in #1665 a few weeks back. This bug has been there from a long time and continues to exist even after the new protocol changes. My current workaround has been to skip the handshake entirely for watchable connections. https://github.com/Aditya-ds-1806/dicedb-driver/blob/d362583029ff7c2a5c0e91c99e6987fe08f6b6cd/lib/DiceDBSocket.ts#L260-L268

Aditya-ds-1806 avatar May 13 '25 16:05 Aditya-ds-1806