Migrated ZPOPMIN Command

[prabhavdogra]

Depends on ZADD Command

Summary by CodeRabbit

• New Features
  • Introduced a new command that removes and returns the lowest-scoring members from a sorted set, complete with usage information and robust error handling.
  • Enhanced sorted set functionality with the ability to remove a specified number of minimum elements, dynamically adjusting the results when fewer elements are available.

[coderabbitai[bot]]

Walkthrough

A new command, ZPOPMIN, has been introduced to remove and return the lowest-scoring members from a sorted set. The command is implemented in the command package with detailed help content, argument parsing, and error handling. It integrates with a distributed shard management system to execute on the correct data partition. Additionally, the underlying sorted set structure has been extended with a PopMin method that removes the minimum elements, ensuring consistency in operations.

Changes

Files	Change Summary
internal/cmd/cmd_zpopmin.go	Added new command ZPOPMIN with new functions: evalZPOPMIN, parseZPOPMINArgs, and executeZPOPMIN. Registered via cZPOPMIN with detailed help and error handling.
internal/eval/sortedset/s.../sorted_set.go	Introduced method PopMin(count int) []string to remove minimum elements from the sorted set using B-tree deletion and updating the member map accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CommandDispatcher
    participant ShardManager
    participant DataStore
    participant SortedSet

    Client->>CommandDispatcher: Send command "ZPOPMIN key [count]"
    CommandDispatcher->>ShardManager: executeZPOPMIN(command)
    ShardManager->>DataStore: Validate shard & retrieve sorted set
    DataStore->>SortedSet: Call PopMin(count)
    SortedSet-->>DataStore: Return lowest-scoring members
    DataStore-->>ShardManager: Return results
    ShardManager-->>CommandDispatcher: Aggregate results
    CommandDispatcher-->>Client: Deliver result

Poem

I'm a rabbit with zest, ready to hop,
ZPOPMIN's here, making sorted sets pop!
With a twitch of my nose and a skip in my stride,
I watch low scores vanish, far and wide.
Cheers to clean code and a gentle display,
Hoppy days with each command we relay!
🐇✨

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[arpitbbhayani]

Closing in favour of

• https://github.com/DiceDB/dice/pull/1620
• https://github.com/DiceDB/dice/pull/1692