dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for `COMMAND INFO` command

Open arpitbbhayani opened this issue 1 year ago • 15 comments

Add support for the COMMAND INFO command in DiceDB similar to the COMMAND INFO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Jul 12 '24 10:07 arpitbbhayani

I have created a shallow PR as WIP. #151

shashankdaima avatar Jul 12 '24 16:07 shashankdaima

@shashankdaima Are you still working on this? I don't see any activity on this from couple of weeks

If not, @arpitbbhayani , @JyotinderSingh Could you please assign this to me?

maniSHarma7575 avatar Jul 26 '24 05:07 maniSHarma7575

@shashankdaima Are you still working on this? I don't see any activity on this from couple of weeks

If not, @arpitbbhayani , @JyotinderSingh Could you please assign this to me?

Assigned to you.

JyotinderSingh avatar Jul 26 '24 05:07 JyotinderSingh

Hi @maniSHarma7575, Are you still working on this? I dont see any activity on this issue so far. If not, i would like to take up this issue. Can you assign this to me? cc: @JyotinderSingh,@arpitbbhayani.

sanimesh96 avatar Aug 15 '24 18:08 sanimesh96

Hi @maniSHarma7575, Are you still working on this? I dont see any activity on this issue so far.

If not, i would like to take up this issue. Can you assign this to me?

cc: @JyotinderSingh,@arpitbbhayani.

Assigned

JyotinderSingh avatar Aug 16 '24 04:08 JyotinderSingh

@sanimesh96 Any latest updates on this? Please pull the latest from the master in the PR and move it from Draft to Review.

AshwinKul28 avatar Aug 25 '24 18:08 AshwinKul28

https://github.com/DiceDB/dice/pull/326#issuecomment-2325343608

AshwinKul28 avatar Sep 02 '24 22:09 AshwinKul28

@sanimesh96 any updates on this? we would like to close this as soon as possible. Do you need any help?

arpitbbhayani avatar Sep 08 '24 12:09 arpitbbhayani

This issue is available to be taken up.

JyotinderSingh avatar Sep 17 '24 19:09 JyotinderSingh

@JyotinderSingh - Please assign to me

psrvere avatar Sep 18 '24 00:09 psrvere

@JyotinderSingh I would also like to work on this issue. Please assign it to me. Thanks.

meetghodasara avatar Sep 18 '24 05:09 meetghodasara

@JyotinderSingh Can this issue be assigned to me?

gauravrp avatar Sep 18 '24 05:09 gauravrp

@JyotinderSingh - Please assign to me

Assigned to @gauravrp for now to allow more people to get involved into contributing.

JyotinderSingh avatar Sep 18 '24 05:09 JyotinderSingh

@JyotinderSingh I would also like to work on this issue. Please assign it to me. Thanks.

Assigned to @gauravrp for now to allow more people to get involved into contributing.

JyotinderSingh avatar Sep 18 '24 05:09 JyotinderSingh

@meetghodasara If the PR for this issue has been merged, can we please close it?

gauravrp avatar Oct 02 '24 03:10 gauravrp

Closing, merged as part of https://github.com/DiceDB/dice/pull/612

lucifercr07 avatar Oct 02 '24 15:10 lucifercr07