dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Added ByScore, Limit for ZRANGE

Open vanshavenger opened this issue 1 year ago • 6 comments

  1. Added Offset, Count LImit in ZRANGE
  2. Added BYSCORE

BYLEX is for now a placeholder but yes it is inlcuded as one of the option.

+inf, -inf, Exclusivity all cases handled.

Kindly check and review once. My first time with Golang

vanshavenger avatar Dec 22 '24 21:12 vanshavenger

@lucifercr07 any improvements or any structure changes that needs to be done? It has now BYSCORE and LIMIT Fucntionality

vanshavenger avatar Dec 23 '24 21:12 vanshavenger

#1393

vanshavenger avatar Dec 25 '24 17:12 vanshavenger

@vanshavenger thanks for contributing, will have a look later today.

lucifercr07 avatar Dec 26 '24 09:12 lucifercr07

Sure give me this week time will add the tests. Apologise for the delay. @apoorvyadav1111

vanshavenger avatar Jan 14 '25 14:01 vanshavenger

@apoorvyadav1111 can you check test once, locally it didn't throw any error

vanshavenger avatar Jan 14 '25 16:01 vanshavenger

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant

We have taken a different route with ZRANGE command. hence this PR is redundant now. Thanks for working on the patch. Closing it to keep things clean.

Thanks again.

arpitbbhayani avatar Apr 29 '25 18:04 arpitbbhayani