dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `GEOSEARCHSTORE`

Open arpitbbhayani opened this issue 1 year ago • 5 comments

Add support for the GEOSEARCHSTORE command in DiceDB similar to the GEOSEARCHSTORE command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Nov 07 '24 15:11 arpitbbhayani

@arpitbbhayani i would like to work on this issue

swarajrb7 avatar Nov 07 '24 15:11 swarajrb7

Hi @arpitbbhayani, I would like to take up this issue! Can I work on this task?

tejaswini22199 avatar Nov 09 '24 03:11 tejaswini22199

Hi @swarajrb7, Assigned. Thanks for contributing to DiceDB.

apoorvyadav1111 avatar Nov 09 '24 16:11 apoorvyadav1111

Hi @swarajrb7, are you still working on this issue? Otherwise, I would like to take up the issue.

helios2003 avatar Dec 11 '24 05:12 helios2003

I am working on this issue. I am waiting for other GEO commands like GEORADIUS and GEORADIUSBYMEMEBER_RO to be merged as many of those functions are used in this command.

swarajrb7 avatar Dec 11 '24 06:12 swarajrb7