dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `GEOSEARCH`

Open arpitbbhayani opened this issue 1 year ago • 7 comments

Add support for the GEOSEARCH command in DiceDB similar to the GEOSEARCH command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Nov 07 '24 15:11 arpitbbhayani

Hey @arpitbbhayani I would like to work on this. Can you assign it to me?

Dev79844 avatar Nov 07 '24 15:11 Dev79844

Hi @Dev79844, Assigned. Thanks for contributing to DiceDB.

apoorvyadav1111 avatar Nov 09 '24 16:11 apoorvyadav1111

Hi @arpitbbhayani I would like to contribute to this specific issue. Can you assign it to me too?

Sarthak762 avatar Nov 10 '24 12:11 Sarthak762

@Dev79844 Any update on this ? Are you still working on this ? @apoorvyadav1111 , I would like to contribute to this issue. Can you assign it to me?

vpsinghg avatar Dec 02 '24 05:12 vpsinghg

I am working on this issue. I am waiting for other geo commands like georadius to be merged as many of those functions are used in this command.

Dev79844 avatar Dec 02 '24 05:12 Dev79844

Hello @arpitbbhayani I won't be able to work on this issue for next 10-15 days due to some personal commitments. It would be great if you can assign it to someone else to maintain the momentum of the project.

Dev79844 avatar Dec 16 '24 11:12 Dev79844

I think we can easily finish this up once #1294 is merged, because they share a lot of the same code. Once this is reviewed, I'd happily take this one up.

benbarten avatar Dec 16 '24 13:12 benbarten