dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `GEORADIUSBYMEMBER`

Open arpitbbhayani opened this issue 1 year ago • 3 comments

Add support for the GEORADIUSBYMEMBER command in DiceDB similar to the GEORADIUSBYMEMBER command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Nov 07 '24 15:11 arpitbbhayani

Hey @arpitbbhayani,

I'd like to pick up this issue. Feel free to assign it to me.

benbarten avatar Nov 07 '24 16:11 benbarten

Hi @benbarten , Assigned. Thanks for contributing to DiceDB.

apoorvyadav1111 avatar Nov 09 '24 16:11 apoorvyadav1111

A short update on this one:

I'm in the middle of implementing the logic to find members in the radius of a geo hash/member. Parts of this can likely be re-used or even extracted into a generic function as done in Redis. I'm planning to open a draft PR end of this week to align with other contributors on how to implement other geo commands. See this discussion for reference.

benbarten avatar Nov 13 '24 19:11 benbarten