dice icon indicating copy to clipboard operation
dice copied to clipboard

Refactor Websocket server parser to support space char in values

Open lucifercr07 opened this issue 1 year ago • 3 comments

Description

  • Ref: https://github.com/DiceDB/dice/issues/1029#issuecomment-2435065742
  • For string value with a space (e.g., "name":"New York"), the command parsing and argument splitting in the command parser for websocket server, does not handle this scenario correctly.
  • Refactor parser to handle such scenarios
  • We can refer to httpServer parser for references.

Tasks

  • Refactor websocket server command parser to support space char as key values.
  • Add tests for the given scenario.

lucifercr07 avatar Oct 24 '24 11:10 lucifercr07

Hi @lucifercr07, I am new to the community and would love to take up this issue. Can you assign it to me?

helios2003 avatar Oct 24 '24 12:10 helios2003

@helios2003 let me know incase any details are required for recreating this issue.

vpsinghg avatar Oct 25 '24 11:10 vpsinghg

I have a small question here: Should the key and value both be able to handle in-between spaces or is it only for the value?

helios2003 avatar Oct 25 '24 20:10 helios2003