dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

#1013 Migrating: ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL')

Open SyedMa3 opened this issue 1 year ago • 2 comments

Migrated the following commands: ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL')

Checklist

  • [x] Migrated the evalXXX function with the latest definition
  • [x] Update or add unit tests for the new implementation.
  • [x] All unit tests pass successfully.
  • [x] Ensure all integration tests pass successfully.
  • [ ] Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
  • [ ] Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

Closes: #1013

SyedMa3 avatar Oct 18 '24 19:10 SyedMa3

@SyedMa3 can we validate the docs related to these command once? Meanwhile I'll confirm the HTTP behaviour it shouldn't be the way it's currently, will fix if required.

Since we are just migrating the commands, I did not find any changes that needed to be done in the docs. Any update on the HTTP behavior? @lucifercr07

SyedMa3 avatar Oct 26 '24 09:10 SyedMa3

@SyedMa3 please resolve conflicts. Have raised fix as part of https://github.com/DiceDB/dice/pull/1204

lucifercr07 avatar Oct 26 '24 19:10 lucifercr07

Hi @SyedMa3 Thanks for all the changes, looks fantastic. Related to the document changes, I see EXPIRETIME, TTL, and PTTL commands need a refresh to get aligned with this sample documentation. I know it's a little back and forth but we want to make it production-ready. So please look at the documentation files for these commands and make it align.

AshwinKul28 avatar Oct 27 '24 07:10 AshwinKul28

Hi @SyedMa3 Thanks for all the changes, looks fantastic. Related to the document changes, I see EXPIRETIME, TTL, and PTTL commands need a refresh to get aligned with this sample documentation. I know it's a little back and forth but we want to make it production-ready. So please look at the documentation files for these commands and make it align.

Oh my bad. Missed that. Will push those changes along with modified test cases after #1204 is closed.

SyedMa3 avatar Oct 27 '24 09:10 SyedMa3

Hey hi @SyedMa3 thanks for the effort related to the refactoring. I see #1204 is now closed! you can go ahead and rebase your code with the master and have a look on refreshing the docs.

AshwinKul28 avatar Oct 29 '24 21:10 AshwinKul28