dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `ZRANK`

Open JyotinderSingh opened this issue 1 year ago • 3 comments

Add support for the ZRANK command in DiceDB similar to the ZRANK command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh avatar Oct 17 '24 14:10 JyotinderSingh

Can I work on this?

SyedMa3 avatar Oct 17 '24 14:10 SyedMa3

Can I work on this?

Assigned, good to see you back @SyedMa3!

JyotinderSingh avatar Oct 17 '24 14:10 JyotinderSingh

Can I work on this?

Assigned, good to see you back @SyedMa3!

Glad to be back! Created a PR. Not 100% sure if I have covered all bases since the code has changed a lot from the last time! 😮

SyedMa3 avatar Oct 17 '24 17:10 SyedMa3