dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `LPOP`: Command doesn't support multiple args

Open lucifercr07 opened this issue 1 year ago • 4 comments

Steps to reproduce

> RPUSH mylist "one" "two" "three" "four" "five"
(integer) 5
> LPOP mylist 2
(error) ERR wrong number of arguments for 'lpop' command

Expected output

The expected output when the above set of commands (maybe when run on Redis)

redis> LPOP mylist 2
1) "two"
2) "three"

Observed output

The observed output when the above set of commands when run on DiceDB

0.0.0.0:7379> LPOP mylist 2
(error) ERR wrong number of arguments for 'lpop' command

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behaviour
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

lucifercr07 avatar Oct 15 '24 12:10 lucifercr07

@lucifercr07 I would like to work on this.

bhima2001 avatar Oct 15 '24 13:10 bhima2001

Hey! I am new in the community and didn't know if I could solve this issue but I gave it a go Here are the results

dice-output

I tried including all the testcases I could think of, and tried to get the output as similar as i could to redis output this is the redis output

redis-output

tren03 avatar Oct 15 '24 19:10 tren03

@lucifercr07 If this issue is still open, Can i pick this up?

Dhroov7 avatar Oct 16 '24 18:10 Dhroov7

Hello @tren03,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

Hey Guys,

This issue is exactly what issue number #1057 resolves which I've been working on.

Kripu77 avatar Nov 01 '24 12:11 Kripu77