dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Command Migration of PFADD, PFCOUNT, PFMERGE done #1032

Open surya0180 opened this issue 1 year ago • 6 comments

This PR closes #1032.

Here are things that are done

  • [x] Migrated the evalXXX function with the latest definition
  • [x] Update or add unit tests for the new implementation.
  • [x] All unit tests pass successfully.
  • [x] Ensure all integration tests pass successfully.
  • [x] Ensure integration tests are added for the migrated command on multi-threaded resp server.

surya0180 avatar Oct 15 '24 06:10 surya0180

Ok, Integration tests are not updated. I will update them and add another commit

surya0180 avatar Oct 15 '24 07:10 surya0180

@AshwinKul28 @apoorvyadav1111 @lucifercr07 @JyotinderSingh

The checks have passed and this PR is ready to be reviewed.

surya0180 avatar Oct 15 '24 09:10 surya0180

@benjaminmishra I have made the changes as requested. Please review them and let me know if everything looks fine

surya0180 avatar Oct 15 '24 13:10 surya0180

@surya0180 lets ensure that the corresponding integration tests are migrated as well. cc @AshwinKul28

soumya-codes avatar Oct 15 '24 13:10 soumya-codes

@surya0180 Please add respective RESP integration tests. Thanks

AshwinKul28 avatar Oct 15 '24 13:10 AshwinKul28

@surya0180 lets ensure that the corresponding integration tests are migrated as well. cc @AshwinKul28

Is this what @soumya-codes is referring to?

surya0180 avatar Oct 15 '24 13:10 surya0180