Add support for command `LINSERT` and `LRANGE` #659

[ParvBudh28]

• Adds support for command LINSERT and LRANGE.
• Adds DequeIterator for traversing over the deque. LRANGE command should now be straight forward to implement using the iterator.

[ParvBudh28]

@JyotinderSingh Can you please review this or assign an appropriate reviewer for this.

TIA

[JyotinderSingh]

There seem to be some conflicts, could you please rebase on the latest master?

[ParvBudh28]

There seem to be some conflicts, could you please rebase on the latest master?

Done.

[ParvBudh28]

@JyotinderSingh @apoorvyadav1111 Can you please review this PR.

TIA

[JyotinderSingh]

@ParvBudh28 Could you please update the PR with the requested changes? The state of the PR is quite close to ideal and it will be good to have it merged before conflicts arise.

[ParvBudh28]

@ParvBudh28 Could you please update the PR with the requested changes? The state of the PR is quite close to ideal and it will be good to have it merged before conflicts arise.

I've made the changes as per the comments. Apologies for the delay. Was caught up during the week.

[ParvBudh28]

The changes look good, based on the new PR guidelines please also update the documentation for this command under the docs directory.

Please also fix the merge conflicts and the linter errors.

@JyotinderSingh Done. I've fixed the linter issues and added the documentation as well.

[apoorvyadav1111]

Hi @ParvBudh28, Please find the checklist for new commands/ migration PRs. We are moving away from async server to resp and new commands are added to store_eval.go instead of eval.go.

• [x] moved code from eval.go to store_eval.go
• [x] updated cmd meta in eval, worker & server
• [x] moved tests from async to resp
• [x] added/updated tests in http and websocket
• [x] added/updated unit tests in eval folder
• [x] audited documentation and updated as per new standards
• [x] no changes in legacy async code / eval.go file
• [x] rebased with master
• [ ] verified the code in local

Please checkout the PR #1117 on migration/adding new commands and related artifacts.

Thanks

[ParvBudh28]

Hi @ParvBudh28, Please find the checklist for new commands/ migration PRs. We are moving away from async server to resp and new commands are added to store_eval.go instead of eval.go.

• [x] moved code from eval.go to store_eval.go
• [x] updated cmd meta in eval, worker & server
• [x] moved tests from async to resp
• [ ] added/updated tests in http and websocket
• [x] added/updated unit tests in eval folder
• [x] audited documentation and updated as per new standards
• [x] no changes in legacy async code / eval.go file
• [x] rebased with master
• [x] verified the code in local

Please checkout the PR #1117 on migration/adding new commands and related artifacts.

Thanks

Hi @apoorvyadav1111, I've moved the code away from eval.go to store_eval.go and from async to resp. Please check and let me know if there are any other action items here.

[JyotinderSingh]

@ParvBudh28 The PR is almost ready to be merged, could you please address the last few comments here?

[ParvBudh28]

@ParvBudh28 The PR is almost ready to be merged, could you please address the last few comments here?

Hey, apologies for the delay, I was traveling last week. I have addressed the comments and updated the PR.

[ParvBudh28]

Thanks for addressing all the comments @ParvBudh28! The changes look great. Approved.

@apoorvyadav1111 Is your approval also required to close this PR ?

[apoorvyadav1111]

Hi @ParvBudh28, Please rebase your branch. There are some conflicts which are blocking this merge.

Thanks, Apoorv

[ParvBudh28]

Hi @ParvBudh28, Please rebase your branch. There are some conflicts which are blocking this merge.

Thanks, Apoorv

@apoorvyadav1111 Done.

[JyotinderSingh]

Thanks for the massive effort on this PR @ParvBudh28!