dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Fix: Preserve TTL after APPEND command

Open dankot12 opened this issue 1 year ago • 3 comments

  • Resolved an issue where the TTL was incorrectly reset to -1 after using the APPEND command on a key with an existing TTL.
  • The TTL is now correctly preserved after appending to a key, matching expected behavior in Redis.
  • Added relevant test cases to ensure that TTL is maintained across APPEND operations.
  • Tests include scenarios for key expiration after APPEND and correct TTL decrement over time.

Benchmark

image

Closes #1036

dankot12 avatar Oct 09 '24 02:10 dankot12

Hi @dankot12, Hope you are well. I am excited to know about your progress on this issue. As you know, we would like to close this issue soon, please reach out to me or anyone on the discord community if you need any help.

Thanks.

apoorvyadav1111 avatar Oct 17 '24 12:10 apoorvyadav1111

Hi @dankot12 , please rebase you branch with the latest changes with the migrated eval function. Please reach out to me if you need any clarifications.

apoorvyadav1111 avatar Oct 22 '24 07:10 apoorvyadav1111

Hi @dankot12 , Hope you are well. I am eager to know more about progress on this issue. Please contact me or anyone on the discord community if you are blocked.

Thanks.

apoorvyadav1111 avatar Oct 25 '24 05:10 apoorvyadav1111

@dankot12 please resolve conflicts. https://github.com/DiceDB/dice/pull/1095 is merged now so please fix according to the migrated command.

lucifercr07 avatar Oct 30 '24 10:10 lucifercr07

Hi @lucifercr07, will do this by EOD Eastern Time. Thanks

dankot12 avatar Oct 30 '24 14:10 dankot12

Hi @lucifercr07 @apoorvyadav1111, this PR is ready for your review. Thanks!

dankot12 avatar Oct 31 '24 01:10 dankot12

Hi @dankot12 , Hope you are well. I am eager to know more about progress on this issue. Please contact me or anyone on the discord community if you are blocked.

Thanks.

apoorvyadav1111 avatar Nov 09 '24 16:11 apoorvyadav1111

@dankot12 any updates?

arpitbbhayani avatar Nov 14 '24 05:11 arpitbbhayani

Hi @apoorvyadav1111 @arpitbbhayani, will be working on this today. Thanks.

dankot12 avatar Nov 14 '24 12:11 dankot12

Hi @apoorvyadav1111, the PR is ready for your review.

dankot12 avatar Nov 15 '24 04:11 dankot12

Hi, @dankot12 , please fix the lint errors. we can use object.<Constant> instead of dstore.CONSTANT notation.

apoorvyadav1111 avatar Nov 18 '24 22:11 apoorvyadav1111