subliminal icon indicating copy to clipboard operation
subliminal copied to clipboard

Age filtering when scanning files should use creation date

Open MoshiMoshi0 opened this issue 6 years ago • 5 comments

Currently they are filtered by modified date here, but doesn't creation date make more sense?

If you put/copy new files into the scanned folder they should be treated as new. The modified date will never change unless you re-encode, and that would probably also change the hash and break subtitle detection.

The creation date is platform dependent but I found this stackoverflow answer with cross-platform code.

edit: Probably better to use creation and modified dates and pick the latest? So just max(os.path.getmtime(path), os.path.getctime(path))

MoshiMoshi0 avatar Dec 31 '17 16:12 MoshiMoshi0