subliminal icon indicating copy to clipboard operation
subliminal copied to clipboard
verified publisher icon Diaoul

Remove requirement for episode number when guessing

Open ptrcnull opened this issue 1 year ago • 6 comments

with some types of episodes, such as extras, the episode number will be missing, but the subtitle download succeeds with the check removed

ptrcnull avatar Aug 02 '24 14:08 ptrcnull

Coverage report

Click to see where and how coverage changed
FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  subliminal
  video.py
Project Total  

This report was generated by python-coverage-comment-action

github-actions[bot] avatar Aug 02 '24 14:08 github-actions[bot]

ah, actually, sometimes it just pulls the first episode of the season...

ptrcnull avatar Aug 02 '24 14:08 ptrcnull

Fixes #692

And it would be great if this PR could also tackle #678

They don't look easy to fix though...

getzze avatar Aug 02 '24 23:08 getzze

Are you still working on this? I just realized it's a duplicate of: https://github.com/Diaoul/subliminal/pull/702

getzze avatar Sep 11 '24 22:09 getzze

to be fair, the other MR is flawed in the same way as mine is

ptrcnull avatar Sep 11 '24 22:09 ptrcnull

but to answer your question, i forgot about it, but at some point i'd like to either fix it myself, or see it fixed ^^

ptrcnull avatar Sep 11 '24 22:09 ptrcnull