subliminal
subliminal copied to clipboard
Limit versions of rarfile that can be used
In markokr/rarfile#70 it's reported that the custom_check
function was removed from the rarfile pypi package. As a result the error reported in Diaoul/subliminal#1013 occurs when a version of rarfile newer than 3.1 is installed.
This fixes #1013 by limiting the range of rarfile versions.
Once the legendastv provider is changed to no longer use custom_check
this version constraint could be removed.
The python 2.7 Jenkins tests are failing because of #1029 I'm unsure why the python 3 Jenkins tests are failing, they report
________________________ ERROR collecting test session _________________________
Direct construction of Pep8Item has been deprecated, please use Pep8Item.from_parent.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.
However I don't see any use of from_parent
in the subliminal tests
Alternative solution is #1045, however the setup.py in that should be updated to require >3.1
This PR is waiting on someone to begin maintaining this repo (see #1046) as otherwise there's nobody to merge it.
legendastv Provider was removed
@getzze Do you know what commit it was removed in? It appears to still be present and using the no longer existing custom_check
method, but I could be wrong.
https://github.com/Diaoul/subliminal/blob/f86450918501ef11e26e40eef153654c52a6d8bb/subliminal/providers/legendastv.py
it was 4130a485481dfc893cb6dfddd6e96305aa613f00, but it's only on the develop
branch; you'll have to wait for the new release
Exactly, I was trying to close old PRs, sorry for not giving more information. Thanks @ptrcnull