Fix #767: NPE for IBAN with country code

Open manosbatsis opened this issue 2 years ago • 3 comments

Fixes #767

There is no easy way to control target country randomization when creating IBANs, because both countryCodeToBasicBankAccountNumberPattern and createCountryCodeToBasicBankAccountNumberPatternMap() are private.

This PR adds a Finance.ibanCountryCodes() to allow finer control of scope.

Oct 27 '23 08:10 manosbatsis

Hi @manosbatsis , thanks for submitting this fix. I'd suggest trying out Datafaker, a drop in replacement for Javafaker. We're also very open to contributions!

Oct 27 '23 08:10 bodiam

Hey @bodiam, actually I think datafaker's Finance class has the same issue. Perhaps you'd like the same PR there?

Oct 27 '23 10:10 manosbatsis

Can you reproduce it with Datafaker? If so, absolutely!

Oct 27 '23 11:10 bodiam