java-faker icon indicating copy to clipboard operation
java-faker copied to clipboard

Address for en-NZ Locale is coming with USA specific addresses

Open vibinernesto opened this issue 3 years ago • 2 comments

Describe the bug Address for en-NZ Locale is coming with USA specific addresses. Names as well.

To Reproduce

Faker feku = new Faker(new Locale("en-NZ"));
System.out.println("First Name ---- "+feku.name().firstName());
System.out.println("Last Name ---- "+feku.name().lastName());
System.out.println("Street Address ---- "+feku.address().streetAddress());
System.out.println("City ---- "+feku.address().city());
System.out.println("State ---- "+feku.address().state());
System.out.println("zipCode ---- "+feku.address().zipCode());

It generates below output:

First Name ---- Sophia
Last Name ---- Hahn
Street Address ---- 4209 Cassin Way
City ---- Robertsshire
State ---- California
zipCode ---- 7236

None of them looks like the NZ address book

**Additional comments : ** It makes more sense to add the Maori names in the New Zealand names too

Versions:

  • JDK 8
  • Faker Version 1.0.2

vibinernesto avatar May 09 '22 07:05 vibinernesto

@vibinernesto could you try out Datafaker.net, and see if the issue is there too? We should have fixed a lot of issues currently affecting Javafaker.

update: I just checked it, and it's affecting Datafaker too. It's just because there's no data for en-NZ for this, same as en-GB, en-IND, en-CA, etc. Feel free to add this data and do a PR.

bodiam avatar May 09 '22 07:05 bodiam

Hello @vibinernesto , I would like to fix this issue.

ak-maker avatar May 12 '22 09:05 ak-maker