DiUS
FakerValues.loadValues() never closes inputStream
InputStream from FakerValues.findStream is returned to FakerValues.loadValues() then passed to snake yaml, but it's never closed causing memory and file descriptor leaks.
Calls to faker.username() triggers a call to faker.firstName() which apparently opens a yaml file EACH TIME, for which inputSteam is never closed. Overall resulting in poor performance and a memory leak as the buffers are never released, cached, closed... in 60 seconds of profiling I got 2.8Gb of buffers by simply calling faker.username():
it seems the fix was merged into master branch
@codingricky is there any chance to publish a new release?
@valfirst any chance you'd be willing to try out https://github.com/datafaker-net/datafaker ? The issue is fixed there, plus many other issues.
@bodiam is https://github.com/datafaker-net/datafaker independent or do you plan to migrate fixes done in this project to your fork?
So far, I've merged every PR of this project where the quality was reasonable into my fork, and I'm planning to keep doing that.
Besides that, I've fixed several issues in this project in my fork. They can be merged back into this project if the owners want to, but some PRs with fixes were open for more than 3 years.
On 31 Dec 2021, at 05:45, Valery Yatsynovich @.***> wrote:
@bodiam is https://github.com/datafaker-net/datafaker independent or do you plan to migrate fixes done in this project to your fork?
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.