Dmitriy Fuks

Results 36 comments of Dmitriy Fuks

I've made progress in finding a solution. The issue in my case is that [getSemanticDiagnostics](https://github.com/microsoft/TypeScript/blob/6add96fd18d126d1505de5d96f0df6a86e5f2c21/src/compiler/builder.ts#L1783C14-L1783C36) is called not from the program but from builderProgram. In turn, it calls [getSemanticDiagnosticsOfFile](https://github.com/microsoft/TypeScript/blob/6add96fd18d126d1505de5d96f0df6a86e5f2c21/src/compiler/builder.ts#L946). Only...

[The final version of the solution](https://github.com/DiFuks/ts-overrides-plugin-example/blob/7d6c172be997055b645869d9817760c232695fd9/packages/plugin/src/cli/index.ts#L65) For some reason, overriding getProgramDiagnostics also didn't yield results - it returned an empty array. In the end, I had to override getBindAndCheckDiagnostics. As...

@artem1458 Thank you! Oddly, the solution[ presented here](https://github.com/DiFuks/ts-overrides-plugin-example/blob/7d6c172be997055b645869d9817760c232695fd9/packages/plugin/src/cli/index.ts#L65) works well with ForkTSChecker. Unfortunately, my team specifically uses ForkTSChecker. :(

How do you use hooks inside promises? Hooks should only be called in the body of components

This is described in the documentation and any tutorials. I'm not the maintainer of react, but it seems to me that the plugin should not check such things.

This problem occurs in this line: https://github.com/frankwallis/react-slidedown/blob/master/lib/slidedown.tsx#L92 Suppose that when changing the component props, its height has not changed, and closed = true. Then ```javascript endHeight = getComputedStyle(this.outerRef).height ``` The...