elasticsearch-lua icon indicating copy to clipboard operation
elasticsearch-lua copied to clipboard

add http basic auth for X-Pack plugin

Open tanhaipeng opened this issue 5 years ago • 6 comments

fix #29

tanhaipeng avatar Oct 12 '18 03:10 tanhaipeng

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fbebbc31cae53d5f65672e3670f5c9be3d1 on tanhaipeng:master into 490f6b24b46ef79125c864ef3b4b8d5073a60cd0 on DhavalKapil:master.

coveralls avatar Oct 12 '18 04:10 coveralls

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fbebbc31cae53d5f65672e3670f5c9be3d1 on tanhaipeng:master into 490f6b24b46ef79125c864ef3b4b8d5073a60cd0 on DhavalKapil:master.

coveralls avatar Oct 12 '18 04:10 coveralls

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fbebbc31cae53d5f65672e3670f5c9be3d1 on tanhaipeng:master into 490f6b24b46ef79125c864ef3b4b8d5073a60cd0 on DhavalKapil:master.

coveralls avatar Oct 12 '18 04:10 coveralls

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html It was renamed to lua_rawlen in 5.2. You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

tanhaipeng avatar Oct 12 '18 07:10 tanhaipeng

I'll look at the cjson issue separately, it's a pita TBH. I'll have to build lua manually in travis rather than use the built-in lua.

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html It was renamed to lua_rawlen in 5.2. You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

neilcook avatar Nov 02 '18 15:11 neilcook

If you can add some tests for the authentication code I'd be happy to merge.

neilcook avatar Nov 02 '18 15:11 neilcook