pem icon indicating copy to clipboard operation
pem copied to clipboard

Published 20 hours ago • verified publisher icon Dexus

use DEBUG flag instead of CI

Open simon-q opened this issue 1 year ago • 3 comments

CI is set to true in CI/CD tools such as Bitbucket pipelines. That results in excessive debug log if pem library is used in scripts that run in CI/CD of other projects, e.g. when pem library is used in tests that are running in a Bitbucket pipeline. It would be therefore better to use a different flag than CI to control when debug logs are produced. This PR suggests DEBUG flag.

simon-q avatar Apr 13 '23 12:04 simon-q

Hi @Dexus, could you please have a look?

cernytomas avatar Aug 01 '23 12:08 cernytomas

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

Dexus avatar Aug 07 '23 15:08 Dexus

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

I made requested changes https://github.com/Dexus/pem/pull/373

cernytomas avatar Oct 31 '23 10:10 cernytomas