Devwill2

Results 63 comments of Devwill2

@binary-koan Some test failures are due to service timeouts. One looks unrelated? I think we’re on the right track.

@4arjun I have one question. All your Audience One test cases are passing on the main branch, but my Audience One specs are failing. Could you tell me which command...

> > @4arjun I have one question. All your Audience One test cases are passing on the main branch, but my Audience One specs are failing. Could you tell me...

> @Devwill2 That's because your endpoint should be returning json > > > and with json you can't use symbols as you're doing in your [specs](https://github.com/antiwork/gumroad/pull/2484/changes#diff-3b4e360a182c9ef3b4872cda3c3214b82379ff650f6570b2f3f618c1a3c42d53R53) > > ```ruby >...

@EmCousin Currently, the tabs use regular tags which cause a full page reload. This is intentional because the UTM Links page is not yet migrated to Inertia, and the shared...

Thanks @Pradumn27 Switched to lambda as suggested. Keeping the conditional since when `total_follower_count === 0`, we want to skip defining the prop entirely (not just delay the query). This avoids...

> Thanks @Pradumn27 Switched to lambda as suggested. Keeping the conditional since when `total_follower_count === 0`, we want to skip defining the prop entirely (not just delay the query). This...

@binary-koan Can you review this, please? I’ve completed all the changes and think it’s good to go. Thanks for your time

> > Could you check the failing tests? > > @binary-koan Could you please review the PR #2463? This PR was opened earlier. As mentioned by @4arjun, it is not...

@binary-koan I think two tests are flaky, and one of them seems related. I noticed you made some commits to simplify the spec—am I correct?