jfairy icon indicating copy to clipboard operation
jfairy copied to clipboard

FR data generation uses Spanish implementation

Open OlgaMaciaszek opened this issue 6 years ago • 1 comments

This code is currently present in Bootstrap.java:

case FR:
    return new EsFairyModule(dataMaster, randomGenerator);

OlgaMaciaszek avatar Jun 08 '18 12:06 OlgaMaciaszek

This appears to be an intentional shortcut for using the Spanish identity card and address implementations for the FR locale. I would have expected the IT locale to be treated similar to FR but at present it falls through to the default clause.

    default:
		LOG.info("No data for your language - using the default EN"); 
		return new EnFairyModule(dataMaster, randomGenerator);

A cleaner construct may be to define an EUFairyModule that can be reused for most EU countries.

jhansoty73 avatar Sep 18 '18 19:09 jhansoty73