Nabla icon indicating copy to clipboard operation
Nabla copied to clipboard
verified publisher icon Devsh-Graphics-Programming

New debug draw extension for AABBs

Open keptsecret opened this issue 6 months ago • 2 comments

keptsecret avatar Jul 08 '25 08:07 keptsecret

@keptsecret Example build is failing, I can see that without the Debug Draw extensions example 12 is now broken

C:\mount\nabla\examples_tests\12_MeshLoaders\main.cpp(390): error C2065: 'm_aabbInstances': undeclared identifier

devshgraphicsprogramming avatar Sep 06 '25 10:09 devshgraphicsprogramming

@keptsecret still broken on the CI


C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(90): error C2065: 'builtin': undeclared identifier
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(90): error C2653: 'builtin': is not a class or namespace name
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(90): error C2065: 'CArchive': undeclared identifier
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(90): error C2672: 'make_smart_refctd_ptr': no matching overloaded function found
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(123): note: could be 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::make_smart_refctd_ptr(Args ...)'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(90): note: 'nbl::core::make_smart_refctd_ptr': invalid template argument for 'T', type expected
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C3536: 'archive': cannot be used before it is initialized
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2641: cannot deduce template arguments for 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &&) noexcept': could not deduce template argument for 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &&' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(69): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<T> &&) noexcept': could not deduce template argument for 'nbl::core::smart_refctd_ptr<T> &&' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(65): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(const nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &) noexcept': could not deduce template argument for 'const nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(59): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(const nbl::core::smart_refctd_ptr<T> &) noexcept': could not deduce template argument for 'const nbl::core::smart_refctd_ptr<T> &' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(55): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2780: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(U *,nbl::core::dont_grab_t) noexcept': expects 2 arguments - 1 provided
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(52): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(U *) noexcept': could not deduce template argument for 'U *' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(50): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2783: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(std::nullptr_t) noexcept': could not deduce template argument for 'I_REFERENCE_COUNTED'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(48): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2780: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(void) noexcept': expects 0 arguments - 1 provided
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(47): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(91): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED>)': could not deduce template argument for 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED>' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(22): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2641: cannot deduce template arguments for 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &&) noexcept': could not deduce template argument for 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &&' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(69): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<T> &&) noexcept': could not deduce template argument for 'nbl::core::smart_refctd_ptr<T> &&' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(65): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(const nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &) noexcept': could not deduce template argument for 'const nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> &' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(59): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(const nbl::core::smart_refctd_ptr<T> &) noexcept': could not deduce template argument for 'const nbl::core::smart_refctd_ptr<T> &' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(55): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2780: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(U *,nbl::core::dont_grab_t) noexcept': expects 2 arguments - 1 provided
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(52): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(U *) noexcept': could not deduce template argument for 'U *' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(50): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2783: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(std::nullptr_t) noexcept': could not deduce template argument for 'I_REFERENCE_COUNTED'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(48): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2780: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(void) noexcept': expects 0 arguments - 1 provided
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(47): note: see declaration of 'nbl::core::smart_refctd_ptr'
C:\mount\nabla\src\nbl\ext\DebugDraw\CDrawAABB.cpp(98): error C2784: 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED> nbl::core::smart_refctd_ptr(nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED>)': could not deduce template argument for 'nbl::core::smart_refctd_ptr<I_REFERENCE_COUNTED>' from 'int'
C:\mount\nabla\include\nbl/core/decl/smart_refctd_ptr.h(22): note: see declaration of 'nbl::core::smart_refctd_ptr'
[3 jobs, 133/477 edges, 2.5e/s, elapsed 00:52s]: Creating "C:/mount/nabla/build-ct/examples_tests/27_MPMCScheduler/auto-gen/shader.spv"

please test thoroughly in different configs

devshgraphicsprogramming avatar Sep 11 '25 14:09 devshgraphicsprogramming

conflict on examples_tests needs resolving (probably just merge master to both branches)

devshgraphicsprogramming avatar Dec 15 '25 06:12 devshgraphicsprogramming