Nabla icon indicating copy to clipboard operation
Nabla copied to clipboard

Add logging for nbl::video device calls

Open tad1 opened this issue 1 year ago • 4 comments

Description

Add a bunch of error logs for ILogicalDevice methods to disambiguate failures. Add _NBL_DEBUG_BREAK_IF on DEVICE_LOST

  • resolves #684

testing

compiles, checked formatting tested regression in:

  • 24th ColorSpace example
  • 62th CAD example

coverage

  • [x] ILogicalDevice.h
  • [x] ILogicalDevice.cpp
  • [X] IQueue.cpp

tad1 avatar Aug 06 '24 18:08 tad1

@devshgraphicsprogramming I think this covers the scope of #684

tad1 avatar Aug 07 '24 19:08 tad1

@Erfan-Ahmadi review rest and press the green button

Go to IQueue.cpp improve the logging there to have the same format as what you currently have. also add additional logging based on submit result near the end of the function (line 87), that can have DEVICE_LOST as well

Erfan-Ahmadi avatar Aug 09 '24 07:08 Erfan-Ahmadi

Go to IQueue.cpp improve the logging there to have the same format as what you currently have. also add additional logging based on submit result near the end of the function (line 87), that can have DEVICE_LOST as well

done

tad1 avatar Aug 11 '24 11:08 tad1