Nabla icon indicating copy to clipboard operation
Nabla copied to clipboard

Published 20 hours ago • verified publisher icon Devsh-Graphics-Programming

CommandBuffer::Begin needs to release resources

Open Erfan-Ahmadi opened this issue 2 years ago • 1 comments

CommandBuffer::Begin doesn't act like CommandBuffer::Reset when the command pool is created with the RESET_COMMAND_BUFFER flag. It's not a matter of Vulkan API calls, it's a matter of releasing the references that command buffer holds onto in our internal command buffer implementation.

To reproduce: https://github.com/Devsh-Graphics-Programming/Nabla-Examples-and-Tests/commit/11748d017d9e9ffe84414ccb0ab7169109d28f4b

Erfan-Ahmadi avatar Aug 03 '22 13:08 Erfan-Ahmadi

A little bit of context, I think that right now the OpenGL commandbuffer will hold onto the images while the Vulkan one will not :D (due to the VK one doing literally nothing at record except forward the image types)

devshgraphicsprogramming avatar Aug 08 '22 13:08 devshgraphicsprogramming

@achalpandeyy make sure to do one commit on your branch with message Fix #407 then this issue will autoclose after I approve the PR

devshgraphicsprogramming avatar Sep 22 '22 11:09 devshgraphicsprogramming

Done here https://github.com/Devsh-Graphics-Programming/Nabla/pull/345/commits/06f524ff0a0ac757e7a190735f47aac5dc940d83

achalpandeyy avatar Sep 23 '22 17:09 achalpandeyy