Used async enumerators
Fix: #111
Description:
- Used IAsyncEnumerators instead of IEnumerators
- GetRecords implementations are now async
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Gulin7 Nice work, thanks. Did all the unit tests pass?
@Gulin7 I suggest you run the following chatGPT prompt over this PR and consider updating documentation appropriately.
Given this code change, under what scenario would you ever benefit from the old code instead of the new code?
Also, @rofr are you happy not using semver for this project? Perhaps consider marking the existing method as obsolete and create a new method "GetRecordsAsync", and don't add it to the interface, add it to a new interface that derives from the old, so that the new release will be 100% backward compatible?
This code also needs new tests for the new API method.
Alan