memstate icon indicating copy to clipboard operation
memstate copied to clipboard

Used async enumerators

Open Gulin7 opened this issue 1 year ago • 3 comments

Fix: #111

Description:

  • Used IAsyncEnumerators instead of IEnumerators
  • GetRecords implementations are now async

Gulin7 avatar Nov 27 '24 12:11 Gulin7

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '24 12:11 CLAassistant

@Gulin7 Nice work, thanks. Did all the unit tests pass?

rofr avatar Dec 02 '24 20:12 rofr

@Gulin7 I suggest you run the following chatGPT prompt over this PR and consider updating documentation appropriately.

Given this code change, under what scenario would you ever benefit from the old code instead of the new code?

Also, @rofr are you happy not using semver for this project? Perhaps consider marking the existing method as obsolete and create a new method "GetRecordsAsync", and don't add it to the interface, add it to a new interface that derives from the old, so that the new release will be 100% backward compatible?

This code also needs new tests for the new API method.

Alan

goblinfactory avatar Dec 02 '24 21:12 goblinfactory