StateOfJS-2019 icon indicating copy to clipboard operation
StateOfJS-2019 copied to clipboard

[i18n]: seems some paragraph missing from src

Open seognil opened this issue 5 years ago • 3 comments

e.g.

Destructuring The destructuring assignment syntax is a JavaScript expression that makes it possible to unpack values from arrays, or properties from objects, into distinct variables.

can't find it for translation

seognil avatar Dec 24 '19 14:12 seognil

It looks like those descriptions in 'Features' crawls the definition of MDN except Decorator. I think there's a way to crawl definition depending on current language which I do not know.

impodracer avatar Dec 24 '19 17:12 impodracer

Oh right. Currently we get those descriptions through our own API which makes it a little harder to get the correct language. I think for now we can leave them in English, or maybe just hide them?

SachaG avatar Dec 25 '19 00:12 SachaG

Faced this issue as well. The absence of these blocks in locale file leads to displaying descriptions like on the screenshot.

image

For now, I'm adding these blocks into our locale yml for consistency of translation. @SachaG is this ok, at least as a temporary solution?

- key: block.description.proxies
  t: >
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy)

- key: block.description.async_await
  t: >
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function)

- key: block.description.promises
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise)

norskeld avatar Jan 15 '20 10:01 norskeld