vs-make-hidden icon indicating copy to clipboard operation
vs-make-hidden copied to clipboard

parse setting.json with comment

Open MarekLew opened this issue 7 years ago • 2 comments

Where comment is in setting.json then extension don't work:

[devine-davies.make-hidden] Unexpected token / in JSON at position 829: SyntaxError: Unexpected token / in JSON at position 829
	at JSON.parse (<anonymous>)
	at fs.readFile (C:\Users\MyUser\.vscode\extensions\devine-davies.make-hidden-0.32.0\out\src\make-hidden\make-hidden.provider.js:69:47)
	at tryToString (fs.js:449:3)
	at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:436:12)

Problem is parse comment.

MarekLew avatar Dec 14 '17 10:12 MarekLew

Please copy the file or show alert where not parse but do not delete the contents.

MarekLew avatar Feb 16 '18 08:02 MarekLew

No. VSC support setting.json with comment, but this extension use another parser and wrong use it. As far as I remember.

pt., 5 mar 2021, 02:05 użytkownik Alexander Kucheryuk < [email protected]> napisał:

I am not sure if this issue is related to this extension as json does not support comments in general https://stackoverflow.com/questions/244777/can-comments-be-used-in-json

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Devine-Davies/vs-make-hidden/issues/2#issuecomment-791067228, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSBXG3QS23GR5NR5MAFDITTCAU6NANCNFSM4EIHPEPA .

MarekLew avatar Mar 06 '21 22:03 MarekLew